feat(tabs): updated to use correct new tokens#7662
Open
harpalsingh wants to merge 3 commits intomasterfrom
Open
feat(tabs): updated to use correct new tokens#7662harpalsingh wants to merge 3 commits intomasterfrom
harpalsingh wants to merge 3 commits intomasterfrom
Conversation
edleeks87
reviewed
Dec 5, 2025
edleeks87
approved these changes
Dec 5, 2025
|
@harpalsingh Thanks, looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The colors in the new tabs are hard coded netrual grey values, we will update this to use the correct new token values.
Current behaviour
Current visual
Current code example as purely a hex code:
border-color: #8b8b8bff;Updated visual
You can see the updated visual with the design tokens applied. The background is also updated to reflect the most common background they will be used on.
Now you will see tokens applied, e.g
border-color: var(--tab-border-active-alt);Checklist
d.tsfile added or updated if requiredQA
Testing instructions
Simply go to the Tabs story and expect to see the updated visual.