Open
Conversation
edleeks87
reviewed
Feb 6, 2026
Contributor
edleeks87
left a comment
edleeks87
left a comment
There was a problem hiding this comment.
Nice work @nuria1110, some minor suggestions from me
|
|
||
| export interface CrumbProps | ||
| extends Omit< | ||
| extends Pick< |
| const { isDarkBackground } = useBreadcrumbsContext(); | ||
| const { inverse } = useBreadcrumbsContext(); | ||
|
|
||
| if (rest.hasFocus && !deprecatedHasFocusWarn) { |
Contributor
There was a problem hiding this comment.
comment: I think as these props weren't likely to have been used simply annotating the interface will be enough
| <li> | ||
| <StyledCrumb | ||
| ref={ref} | ||
| isCurrent={isCurrent} |
Contributor
There was a problem hiding this comment.
Suggested change
| isCurrent={isCurrent} | |
| $isCurrent={isCurrent} |
DipperTheDan
reviewed
Feb 6, 2026
nuria1110
force-pushed
the
breadcrumbs-audit
branch
2 times, most recently
from
2c01f88 to
43ba2f4
Compare
DipperTheDan
previously approved these changes
Feb 9, 2026
edleeks87
previously approved these changes
Feb 10, 2026
|
Hi @nuria1110 ! I’ve reviewed the Git ticket — the component looks all good to me. |
Aligns Breadcrumbs component to Fusion DS. Updates styles using fusion-tokens and adds new `inverse` prop. Deprecates `isDarkBackground` prop from Breadcrumbs and `hasFocus`, `underline`, `linkSize` and `bold` props from Crumb.
nuria1110
dismissed stale reviews from edleeks87 and DipperTheDan
via
4f56235
nuria1110
force-pushed
the
breadcrumbs-audit
branch
from
43ba2f4 to
4f56235
Compare
paulrobinson88
approved these changes
Feb 20, 2026
DipperTheDan
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Aligns
Breadcrumbscomponent to Fusion DS.:inverseprop.isDarkBackgroundprop from Breadcrumbs.hasFocus,underline,linkSizeandboldprops from Crumb.Current behaviour
Breadcrumbscomponent is not aligned with Fusion DS.Checklist
d.tsfile added or updated if requiredQA
Additional context
There is a bug in
react-docsgen-typescriptwhere the props table will not generate in storybook when a variable is declared outside of the scope of a component exported as default, so I've had to add a named export forCrumbto fix this.Testing instructions