test(advanced-color-picker): refine testing suite

[paulrobinson88]

Proposed behaviour

Removed flaky and duplicate tests from the Playwright file to improve stability and run times for the Advanced Color Picker component.
Amended Interaction tests to cover off aspects which weren't covered in Jest or Playwright.

Current behaviour

The Playwright test file contains a number of tests which are covered in either Jest or Storybook interactions.

Checklist

• Commits follow our style guide
• Related issues linked in commit messages if required
• Screenshots are included in the PR if useful
• All themes are supported if required
• Unit tests added or updated if required
• Playwright automation tests added or updated if required
• Storybook added or updated if required
• Translations added or updated (including creating or amending translation keys table in storybook) if required
• Typescript d.ts file added or updated if required
• Related docs have been updated if required

QA

• Tested in provided StackBlitz sandbox/Storybook
• Add new Playwright test coverage if required
• Carbon implementation matches Design System/designs
• UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Check Storybook interactions pass and work as intended.

[edleeks87]

Suggested change

	expect(screen.getByRole("dialog")).toHaveAttribute(
	expect(screen.getByRole("dialog")).toHaveAccessibleDescription(

[edleeks87]

Suggested change

	expect(screen.getByRole("dialog")).toHaveAttribute(
	expect(screen.getByRole("dialog")).toHaveAccessibleName(

[sianford]

This is not required as focus is set when the button is clicked.

[sianford]

This is not required as focus is set when the call to action button was clicked.

[paulrobinson88]

I initially removed this but the interaction test failed in the pipeline, possibly a timing issue since manually testing and closing it does focus the purple colour but specifically focusing does seem to resolve. The tests did pass in the published Chromatic build and locally though 🤷

[sianford]

This should not be the final assertion. The test is incomplete and does not test the prop. The restoreFocusOnClose prop should return focus to the call to action initial trigger button when the colour picker is closed. There should be a test here that checks that when the colour picker is closed, focus is returned to the initial call to action button.