fix(breadcrumbs): don't render link for selected crumb#7774
Draft
mihai-albu-sage wants to merge 3 commits intomasterfrom
Draft
fix(breadcrumbs): don't render link for selected crumb#7774mihai-albu-sage wants to merge 3 commits intomasterfrom
mihai-albu-sage wants to merge 3 commits intomasterfrom
Conversation
Aligns Breadcrumbs component to Fusion DS. Updates styles using fusion-tokens and adds new `inverse` prop. Deprecates `isDarkBackground` prop from Breadcrumbs and `hasFocus`, `underline`, `linkSize` and `bold` props from Crumb.
mihai-albu-sage
force-pushed
the
FE-7570
branch
from
016fc26 to
afea666
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
When a breadcrumb receives
isCurrentwith the valuetrue, it renders as a styled span instead of a Link. This avoids potential race conditions between breadcrumb styling and Link styling.Current behaviour
Currently, all breadcrumbs are rendered using the Link component. When isCurrent is set, additional styles are applied to that same Link, which can create a race condition between the breadcrumb styles and the link’s default styles.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions