Draft
Conversation
DipperTheDan
previously approved these changes
Feb 18, 2026
edleeks87
previously approved these changes
Feb 19, 2026
src/components/button/button.pw.tsx
Outdated
| }); | ||
|
|
||
| test("should pass when gradient-grey buttonType is used and icon rendered", async ({ | ||
| test("should pass accessibility tests for Button as sibling example", async ({ |
Contributor
There was a problem hiding this comment.
comment: I'm not sure there's anything being tested here that hasn't already be sufficiently covered elsewhere
585f25c
5087251 to
585f25c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
onKeyDownandonBlurcallback behaviour.components.test-pwfile.Current behaviour
There are a number of Playwright tests which are no longer needed which are causing a loss of efficiency in the testing suite of the repo.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Check tests pass correctly.