Skip to content

Comments

test(button): refine testing suite#7776

Draft
paulrobinson88 wants to merge 1 commit intomasterfrom
FE-6450-button-tests
Draft

test(button): refine testing suite#7776
paulrobinson88 wants to merge 1 commit intomasterfrom
FE-6450-button-tests

Conversation

@paulrobinson88
Copy link
Contributor

Proposed behaviour

  • Removed Playwright testing where tests are either covered in Jest or Chromatic tests.
  • Added 2 tests to Jest for onKeyDown and onBlur callback behaviour.
  • Consolidated Accessibility testing where the same variant was tested more than once.
  • Removed no longer used code in the components.test-pw file.

Current behaviour

There are a number of Playwright tests which are no longer needed which are causing a loss of efficiency in the testing suite of the repo.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Check tests pass correctly.

DipperTheDan
DipperTheDan previously approved these changes Feb 18, 2026
edleeks87
edleeks87 previously approved these changes Feb 19, 2026
});

test("should pass when gradient-grey buttonType is used and icon rendered", async ({
test("should pass accessibility tests for Button as sibling example", async ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: I'm not sure there's anything being tested here that hasn't already be sufficiently covered elsewhere

@edleeks87 edleeks87 self-requested a review February 19, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants