Skip to content

Comments

chore(fieldset): add next internal component#7781

Draft
nuria1110 wants to merge 1 commit intomasterfrom
fieldset-next
Draft

chore(fieldset): add next internal component#7781
nuria1110 wants to merge 1 commit intomasterfrom
fieldset-next

Conversation

@nuria1110
Copy link
Contributor

Proposed behaviour

Adds new internal fieldset component to be used in CheckboxGroup, RadioButtonGroup, NumeralDate and Time components once they are aligned with the DS. This allows for components to be updated separately, avoids duplication and ensures consistency across components.

image

Current behaviour

Internal Fieldset component contains legacy props and styles.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Adds new internal fieldset component with fusion-tokens to be used in
Checkbox, RadioButton, NumeralDate and Time components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant