fix: ensure sing-box service wait for network online#3671
Closed
everyx wants to merge 1 commit intoSagerNet:dev-nextfrom
Closed
fix: ensure sing-box service wait for network online#3671everyx wants to merge 1 commit intoSagerNet:dev-nextfrom
everyx wants to merge 1 commit intoSagerNet:dev-nextfrom
Conversation
ensure sing-box service wait for network online by adding `network-online.target` dependency
d001460 to
89f0046
Compare
Member
|
Is this fix really necessary? The error you mentioned starts in the background, doesn't block the startup process, and |
Contributor
Author
@nekohasekai Well, it doesn't seem appropriate to add unnecessary boot blocking to the system just to eliminate some harmless logs, so I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a DNS server of type
dhcpon Linux may lead to the following error during startup, we should ensure sing-box service wait for network online by addingnetwork-online.targetdependency: