Require configured token for uploading coverage#70
Open
glopesdev wants to merge 2 commits intoSainsburyWellcomeCentre:mainfrom
Open
Require configured token for uploading coverage#70glopesdev wants to merge 2 commits intoSainsburyWellcomeCentre:mainfrom
glopesdev wants to merge 2 commits intoSainsburyWellcomeCentre:mainfrom
Conversation
This prevents checks failing on forks.
glopesdev
force-pushed
the
code-coverage-report
branch
from
3dcec97 to
7fe7634
Compare
Contributor
Author
|
@lochhh This currently prevents PRs and contributor forks. Reading through the referenced issues and various other PRs I admit I was left pretty confused about the recommended course of action. Some projects simply disable Others seem to go different levels of tortuous routes between configuring the org to accept tokenless uploading of reports (not sure if this is still allowed) to detecting whether secrets are configured or if the CI is running in a fork. I tried to survey a few of these and did not find anything satisfying so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents checks failing on forks. Potentially related to codecov/feedback#301 and codecov/engineering-team#1574.