Rename magnetic encoder and message log classes#71
Draft
Conversation
Both reader and stream classes are renamed. Note this will change the name of dotmap entries in legacy StreamGroup based schemas. The intensity attribute has also been renamed as magnitude to match the schema of the output expander device.
Only the low-level reader class has been renamed. The impact of this change in folder structure and schemas should be minimal.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 78.47% 78.47%
=======================================
Files 15 15
Lines 776 776
=======================================
Hits 609 609
Misses 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename magnetic encoder reader
Both reader and stream classes are renamed. Note this will change the name of dotmap entries in legacy StreamGroup based schemas. The intensity attribute has also been renamed as magnitude to match the schema of the output expander device.
Rename message log reader
Only the low-level reader class has been renamed. The impact of this change in folder structure and schemas should be minimal.
Fixes #55