fix(themes): Fix JS window settings serialization using json_encode#829
Open
Ahmed-S-Abduallah wants to merge 1 commit intomasterfrom
Open
fix(themes): Fix JS window settings serialization using json_encode#829Ahmed-S-Abduallah wants to merge 1 commit intomasterfrom
Ahmed-S-Abduallah wants to merge 1 commit intomasterfrom
Conversation
Ahmed-S-Abduallah
requested review from
ashrafreda and
jalmatari
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix Array-to-string conversion in theme Twig → JS injection
Summary
Fixes "Array to string conversion" errors when theme/store settings are passed into JavaScript. Any setting that can be an array (or object) was being output as a string, which caused runtime errors.
Changes
master.twig(all affected themes)Replaced direct string interpolation of
theme.settings.get(...)and similar values with| json_encode | rawso values are safely serialized for JS (strings, booleans, arrays, objects).Result