Add missing Arrange/Act/Assert comments and improve exception specificity in SkittleTests#293
Merged
samsmithnz merged 3 commits intomainfrom Dec 4, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 19936861958Details
💛 - Coveralls |
…city in SkittleTests Co-authored-by: samsmithnz <8389039+samsmithnz@users.noreply.github.com>
Co-authored-by: samsmithnz <8389039+samsmithnz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing comments for consistency in Skittle tests
Add missing Arrange/Act/Assert comments and improve exception specificity in SkittleTests
Dec 4, 2025
samsmithnz
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies consistency fixes to test methods in
SkittleTests.csby adding missing AAA pattern comments and improving exception type specificity.Changes
Test comments: Added
//Arrange,//Act, and//Assertcomments toCountSkittlesInA1CubicNullUnitTest()andCountSkittlesInACylinderWithNullUnitTest()for consistency with other tests in the classException specificity: Changed
Assert.Throws<Exception>toAssert.Throws<ArgumentNullException>inCountSkittlesInANullUnitTest()and updatedCalculator.GetCubicCmForVolume()to throwArgumentNullExceptionwhen unit is null/empty:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.