Fix for Equality check on floating point values#294
Merged
samsmithnz merged 5 commits intomainfrom Dec 4, 2025
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 19940565103Details
💛 - Coveralls |
Collaborator
Author
|
@copilot, make sure you fix this rule on all methods in this file. |
Contributor
|
@samsmithnz I've opened a new pull request, #299, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: samsmithnz <8389039+samsmithnz@users.noreply.github.com>
Fix floating point equality checks in SkittleTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this issue, replace the equality comparison with an "approximate equality" comparison: check that the two values are within a small tolerance (
delta). UseAssert.AreEqualwith thedeltaparameter, which is standard in MSTest for this purpose. Specifically, inAssert.AreEqual(expected, actual, delta), the assertion passes ifMath.Abs(expected - actual) <= delta.Therefore, replace line 25:
with:
Here,
1fis a reasonable tolerance given we are rounding to whole numbers of skittles. Repeat this pattern for lines 40 and 55, which make similar comparisons for values848fand212f.No extra imports or methods are needed, since
Assertis already in scope andAreEqualis part of MSTest.Suggested fixes powered by Copilot Autofix. Review carefully before merging.