Fix for Equality check on floating point values#296
Merged
samsmithnz merged 5 commits intomainfrom Dec 4, 2025
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 19939620337Details
💛 - Coveralls |
Collaborator
Author
|
@copilot, make sure you fix this rule on all methods in this file. |
Contributor
|
@samsmithnz I've opened a new pull request, #297, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: samsmithnz <8389039+samsmithnz@users.noreply.github.com>
Fix floating-point equality checks in all test assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the problem, floating-point values should not be compared directly using
==. Instead, we should compare the absolute difference between the calculated value and the expected value against a small "epsilon" value, which defines the acceptable margin of error due to floating point imprecision.Since the assertion is about a rounded number of M&Ms, and the expected value is an integer, we can either (1) compare integer values by casting the rounded value to an integer, or (2) define a small tolerance for float comparison (using something like
Math.Abs(a - b) < epsilon). Using the integer comparison is simple and appropriate here since the value is rounded to zero decimals.Therefore, in this file, change line 124 from:
to:
This will assert the rounded value equals 5 as an integer, which avoids all floating point equality issues.
Make similar changes on lines 96 and 110.
No new imports are needed, as
Mathis already in use.Suggested fixes powered by Copilot Autofix. Review carefully before merging.