Skip to content

[WIP] Fix exception type assertion in SkittleTests#301

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-exception-type-assertion
Closed

[WIP] Fix exception type assertion in SkittleTests#301
Copilot wants to merge 1 commit intomainfrom
copilot/fix-exception-type-assertion

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 4, 2025

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"Catching the generic Exception type is too broad. Consider asserting for a more specific exception type like ArgumentNullException to match the pattern used in line 112.","fixFiles":[{"filePath":"src/MandMCounter.Tests/SkittleTests.cs","diff":"diff --git a/src/MandMCounter.Tests/SkittleTests.cs b/src/MandMCounter.Tests/SkittleTests.cs\n--- a/src/MandMCounter.Tests/SkittleTests.cs\n+++ b/src/MandMCounter.Tests/SkittleTests.cs\n@@ -178,7 +178,7 @@\n             //Act\n \n             //Assert\n-            Assert.Throws<Exception>(() => Calculator.CountSkittles(unit, height, width, length));\n+            Assert.Throws<ArgumentNullException>(() => Calculator.CountSkittles(unit, height, width, length));\n         }\n \n         #endregion\n"}]},{"message":"Catching the generic Exception type is too broad. Consider asserting for a more specific exception type like ArgumentNullException to match the pattern used in line 112.","fixFiles":[{"filePath":"src/MandMCounter.Tests/SkittleTests.cs","diff":"diff --git a/src/MandMCounter.Tests/SkittleTests.cs b/src/MandMCounter.Tests/SkittleTests.cs\n--- a/src/MandMCounter.Tests/SkittleTests.cs\n+++ b/src/MandMCounter.Tests/SkittleTests.cs\n@@ -226,7 +226,7 @@\n             float radius = 5;\n \n             //Act & Assert\n-            Assert.Throws<Exception>(() => Calculator.CountSkittles(unit, height, radius));\n+            Assert.Throws<ArgumentNullException>(() => Calculator.CountSkittles(unit, height, radius));\n         }\n \n         #endregion\n"}]},{"message":"[nitpick] Empty line after //Act comment is unnecessary and appears consistently throughout the test file, creating visual clutter.","fixFiles":[{"filePath":"src/MandMCounter.Tests/SkittleTests.cs","diff":"diff --git a/src/MandMCounter.Tests/SkittleTests.cs b/src/MandMCounter.Tests/SkittleTests.cs\n--- a/src/MandMCounter.Tests/SkittleTests.cs\n+++ b/src/MandMCounter.Tests/SkittleTests.cs\n@@ -18,7 +18,6 @@\n             float quantity = 1f;\n \n             //Act\n-            \n             float result = Calculator.CountSkittles(unit, quantity);\n \n             //Assert\n@@ -33,7 +32,6 @@\n             float quantity = 1f;\n \n             //Act\n-            \n             float result = Calculator.CountSkittles(unit, quantity);\n \n             //Assert\n@@ -48,7 +46,6 @@\n             float quantity = 1f;\n \n             //Act\n-            \n             float result = Calculator.CountSkittles(unit, quantity);\n \n             //Assert\n"}]},{"message":"The class name 'UnitsTests' should be 'UnitTests' to follow standard naming conventions for test classes.","fixFiles":[{"filePath":"src/MandMCounter.Tests/UnitsTests.cs","diff":"diff --git a/src/MandMCounter.Tests/UnitsTests.cs b/src/MandMCounter.Tests/UnitsTests.cs\n--- a/src/MandMCounter.Tests/UnitsTests.cs\n+++ b/src/MandMCounter.Tests/UnitsTests.cs\n@@ -7,7 +7,7 @@\n {\n     [System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]\n     [TestClass]\n-    public class UnitsTests\n+    public class UnitTests\n     {\n         [TestMethod]\n         public void GetUnitsForVolumeTest()\n"}]},{"message":"Use Assert.IsNotNull(results) instead of Assert.IsTrue(results != null) for clearer intent and better error messages.","fixFiles":[{"filePath":"src/MandMCounter.Tests/UnitsTests.cs","diff":"diff --git a/src/MandMCounter.Tests/UnitsTests.cs b/src/MandMCounter.Tests/UnitsTests.cs\n--- a/src/MandMCounter.Tests/UnitsTests.cs\n+++ b/src/MandMCounter.Tests/UnitsTests.cs\n@@ -18,7 +18,7 @@\n             List<string> results = Units.GetUnitsForVolume();\n \n             //Assert\n-            Assert.IsTrue(results != null);\n+            Assert.IsNotNull(results);\n             Assert.IsTrue(results.Count > 0);\n             Assert.IsTrue(string.IsNullOrEmpty(results[0]) == false);\n         }\n@@ -32,7 +32,7 @@\n             List<string> results = Units.GetUnitsForContainer();\n \n             //Assert\n-            Assert.IsTrue(results != null);\n+            Assert.IsNotNull(results);\n             Assert.IsTrue(results.Count > 0);\n             Assert.IsTrue(string.IsNullOrEmpty(results[0]) == false);\n         }\n"}]},{"message":"[nitpick] Consider using CollectionAssert.IsNotEmpty(results) or Assert.IsTrue(results.Any()) for more descriptive collection assertions.","fixFiles":[{"filePath":"src/MandMCounter.Tests/UnitsTests.cs","diff":"diff --git a/src/MandMCounter.Tests/UnitsTests.cs b/src/MandMCounter.Tests/UnitsTests.cs\n--- a/src/MandMCounter.Tests/UnitsTests.cs\n+++ b/src/MandMCounter.Tests/UnitsTests.cs\n@@ -19,7 +19,7 @@\n \n             //Assert\n             Assert.IsTrue(results != null);\n-            Assert.IsTrue(results.Count > 0);\n+            CollectionAssert.IsNotEmpty(results);\n             Assert.IsTrue(string.IsNullOrEmpty(results[0]) == false);\n       ...

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@samsmithnz samsmithnz closed this Dec 4, 2025
@samsmithnz samsmithnz deleted the copilot/fix-exception-type-assertion branch December 4, 2025 19:12
Copilot AI requested a review from samsmithnz December 4, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants