Skip to content

Foo fighter upgrades#1137

Merged
samsmithnz merged 4 commits intomainfrom
FooFighterUpgrades
Dec 24, 2025
Merged

Foo fighter upgrades#1137
samsmithnz merged 4 commits intomainfrom
FooFighterUpgrades

Conversation

@samsmithnz
Copy link
Copy Markdown
Collaborator

This pull request focuses on code cleanup and modernization for the FooFighters-related controllers, data access layers, and associated test cases. The main changes include refactoring the usage of base class methods in data access classes, removing unnecessary using directives, and updating test assertions to use more expressive and modern assertion methods.

@samsmithnz samsmithnz enabled auto-merge December 24, 2025 12:43
@samsmithnz samsmithnz merged commit 847b298 into main Dec 24, 2025
14 checks passed
@samsmithnz samsmithnz deleted the FooFighterUpgrades branch December 24, 2025 12:46
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 20486449235

Details

  • 15 of 19 (78.95%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SamSmithNZ.Service/DataAccess/FooFighters/ShowDataAccess.cs 4 6 66.67%
src/SamSmithNZ.Service/DataAccess/FooFighters/SongDataAccess.cs 4 6 66.67%
Totals Coverage Status
Change from base Build 20474621211: 0.0%
Covered Lines: 1768
Relevant Lines: 2716

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants