Skip to content

Major ELO performance updates.#1139

Merged
samsmithnz merged 2 commits intomainfrom
ELOPerformanceUpdates
Dec 24, 2025
Merged

Major ELO performance updates.#1139
samsmithnz merged 2 commits intomainfrom
ELOPerformanceUpdates

Conversation

@samsmithnz
Copy link
Copy Markdown
Collaborator

@samsmithnz samsmithnz commented Dec 24, 2025

fixes #24

This pull request introduces significant optimizations to the Elo rating update process for World Cup tournaments. The main improvements include batching updates to games and tournament teams, reducing redundant database calls, and optimizing how Elo ratings are calculated and stored. These changes enhance both performance and maintainability.

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@samsmithnz samsmithnz merged commit ca94e3b into main Dec 24, 2025
14 checks passed
@samsmithnz samsmithnz deleted the ELOPerformanceUpdates branch December 24, 2025 20:58
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 25, 2025

Pull Request Test Coverage Report for Build 20493633591

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 72 of 106 (67.92%) changed or added relevant lines in 1 file are covered.
  • 99 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-3.9%) to 58.781%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SamSmithNZ.Service/DataAccess/WorldCup/EloRatingDataAccess.cs 72 106 67.92%
Files with Coverage Reduction New Missed Lines %
src/SamSmithNZ.Service/DataAccess/WorldCup/TournamentTeamDataAccess.cs 6 53.85%
src/SamSmithNZ.Service/DataAccess/WorldCup/GameDataAccess.cs 17 68.52%
src/SamSmithNZ.Service/DataAccess/WorldCup/EloRatingDataAccess.cs 76 35.12%
Totals Coverage Status
Change from base Build 20488920135: -3.9%
Covered Lines: 1731
Relevant Lines: 2807

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ELO processing is slow - how can we optimize it?

2 participants