Dynamic length of filter pattern#732
Merged
babenek merged 20 commits intoSamsung:mainfrom Jul 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 92.30% 92.36% +0.05%
==========================================
Files 137 137
Lines 5485 5524 +39
Branches 896 897 +1
==========================================
+ Hits 5063 5102 +39
- Misses 269 270 +1
+ Partials 153 152 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xDizzix
requested changes
Jul 11, 2025
Comment on lines
+31
to
+32
| various_pattern_lengths = list(x if DEFAULT_PATTERN_LEN < x else DEFAULT_PATTERN_LEN | ||
| for x in range(MAX_PATTERN_LENGTH + 1)) |
Contributor
There was a problem hiding this comment.
Suggested change
| various_pattern_lengths = list(x if DEFAULT_PATTERN_LEN < x else DEFAULT_PATTERN_LEN | |
| for x in range(MAX_PATTERN_LENGTH + 1)) | |
| various_pattern_lengths = [max(x, DEFAULT_PATTERN_LEN) | |
| for x in range(MAX_PATTERN_LENGTH + 1)] |
| """ | ||
|
|
||
| def __init__(self, config: Config = None, pattern_len: int = DEFAULT_PATTERN_LEN): | ||
| default_patterns = list( |
Contributor
There was a problem hiding this comment.
Use a list comprehension instead of a list + a generator. Please consider introducing a function instead of doing calculations inside the f-string.
| various_pattern_lengths = list(x if DEFAULT_PATTERN_LEN < x else DEFAULT_PATTERN_LEN | ||
| for x in range(MAX_PATTERN_LENGTH + 1)) | ||
|
|
||
| def __init__(self, config: Config = None, pattern_len: Optional[int] = None): |
Comment on lines
+51
to
+52
| self.pattern_lengths = list(pattern_len for _ in range(MAX_PATTERN_LENGTH + 1)) | ||
| self.patterns = list(pattern for _ in range(MAX_PATTERN_LENGTH + 1)) |
Contributor
There was a problem hiding this comment.
Suggested change
| self.pattern_lengths = list(pattern_len for _ in range(MAX_PATTERN_LENGTH + 1)) | |
| self.patterns = list(pattern for _ in range(MAX_PATTERN_LENGTH + 1)) | |
| self.pattern_lengths = [pattern_len] * (MAX_PATTERN_LENGTH + 1) | |
| self.patterns = [pattern] * (MAX_PATTERN_LENGTH + 1) |
xDizzix
approved these changes
Jul 17, 2025
iuriimet
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.