Skip to content

fix: Add missing check for payload#719

Merged
o-kopysov merged 1 commit intomainfrom
fix-exception
Apr 11, 2025
Merged

fix: Add missing check for payload#719
o-kopysov merged 1 commit intomainfrom
fix-exception

Conversation

@o-kopysov
Copy link
Copy Markdown
Collaborator

Pull Request

Description

Current PR adds a check if 'acttion' field is present in the payload.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update
  • Version update (release)

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the fix label Apr 11, 2025
@o-kopysov o-kopysov added this to the v2.1.4 milestone Apr 11, 2025
@o-kopysov o-kopysov self-assigned this Apr 11, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.05%. Comparing base (9570aa9) to head (1718d9c).

Files with missing lines Patch % Lines
src/main/java/com/lpvs/util/LPVSPayloadUtil.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #719      +/-   ##
============================================
- Coverage     94.19%   94.05%   -0.14%     
  Complexity      489      489              
============================================
  Files            40       40              
  Lines          2031     2034       +3     
  Branches        253      254       +1     
============================================
  Hits           1913     1913              
- Misses           49       51       +2     
- Partials         69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit c68cf99 into main Apr 11, 2025
10 checks passed
@o-kopysov o-kopysov deleted the fix-exception branch April 11, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants