[luci] Add additional negative unit test for Reshape#14859
Merged
seanshpark merged 2 commits intoSamsung:masterfrom Mar 24, 2025
Merged
[luci] Add additional negative unit test for Reshape#14859seanshpark merged 2 commits intoSamsung:masterfrom
seanshpark merged 2 commits intoSamsung:masterfrom
Conversation
This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
Contributor
|
Plz follow #14844 (comment) for this too |
seanshpark
previously approved these changes
Mar 21, 2025
Contributor
seanshpark
left a comment
seanshpark
left a comment
There was a problem hiding this comment.
Looking again, doesn't need recipe for testing.
LGTM
Contributor
|
plz resolve conflict |
jinevening
approved these changes
Mar 24, 2025
seanshpark
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds additional unit test for negative scenario where "0" indicates not existing input dimension.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com