Closed
Conversation
This commit adds ModelData class to capabilities to load Circle model. The handled model can be accessible both as a buffer and as luci::Module. The main purpose of the class is to keep both representation synchronized. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer <m.bencer@partner.samsung.com>
mbencer
commented
Apr 16, 2025
| /** | ||
| * @brief Get the loaded model as the buffer. | ||
| */ | ||
| std::vector<uint8_t> &buffer(); |
Contributor
Author
There was a problem hiding this comment.
Buffer representation of the model (after circle::GetMutableModel) is need to change the inputs shapes like shown in https://github.com/Samsung/ONE/pull/14727/files#diff-89115d8f21eafbf362d2bfbe1ea5677c609681b09b0ad094d6eec8a8e6e5a27eR44
mbencer
commented
Apr 16, 2025
| /** | ||
| * @brief Get the loaded model as the module. | ||
| */ | ||
| luci::Module *module(); |
Contributor
Author
There was a problem hiding this comment.
module representation is need to run passes related with shape inference on loco::Graph like shown in https://github.com/Samsung/ONE/pull/14727/files#diff-89115d8f21eafbf362d2bfbe1ea5677c609681b09b0ad094d6eec8a8e6e5a27eR82-R85
Collaborator
|
PTAL #14727 (comment) |
Contributor
Author
|
No more needed. Chosen approach from #15185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds ModelData class to capabilities to load Circle model. The handled model can be accessible both as a buffer and as luci::Module. The main purpose of the class is to keep both representation synchronized.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com