Skip to content

[onert] Add model verification for I/O consistency#16402

Merged
hseok-oh merged 2 commits intoSamsung:masterfrom
batcheu:add_model_verification
Feb 26, 2026
Merged

[onert] Add model verification for I/O consistency#16402
hseok-oh merged 2 commits intoSamsung:masterfrom
batcheu:add_model_verification

Conversation

@batcheu
Copy link
Contributor

@batcheu batcheu commented Feb 24, 2026

This commit adds verification step to ensure loaded models have matching input/output counts with the pipeline configuration.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee jonghwa3.lee@samsung.com


This commit adds verification step to ensure loaded models have
matching input/output counts with the pipeline configuration.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
hseok-oh
hseok-oh previously approved these changes Feb 25, 2026
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
@batcheu
Copy link
Contributor Author

batcheu commented Feb 26, 2026

LGTM

I posted an additional commit for unittest.
Please, take a look again ;)

❯ ./onert/backend/trix/test_onert_trix_backend --gtest_filter="BulkPipeline*"
Running main() from /home/ljh/workspace/soca/one.forked/runtime/externals/GTEST-1.15.2/googletest/src/gtest_main.cc
Note: Google Test filter = BulkPipeline*
[==========] Running 11 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 3 tests from BulkPipelineBufferTest
[ RUN      ] BulkPipelineBufferTest.test_allocate
[       OK ] BulkPipelineBufferTest.test_allocate (0 ms)
[ RUN      ] BulkPipelineBufferTest.test_deallocate
[       OK ] BulkPipelineBufferTest.test_deallocate (0 ms)
[ RUN      ] BulkPipelineBufferTest.test_fillFromFile
[       OK ] BulkPipelineBufferTest.test_fillFromFile (0 ms)
[----------] 3 tests from BulkPipelineBufferTest (0 ms total)

[----------] 4 tests from BulkPipelineManagerTest
[ RUN      ] BulkPipelineManagerTest.test_initilize
[       OK ] BulkPipelineManagerTest.test_initilize (0 ms)
[ RUN      ] BulkPipelineManagerTest.test_shutdown
[       OK ] BulkPipelineManagerTest.test_shutdown (0 ms)
[ RUN      ] BulkPipelineManagerTest.test_execute
[       OK ] BulkPipelineManagerTest.test_execute (0 ms)
[ RUN      ] BulkPipelineManagerTest.test_verify_models
Failed to initialize pipeline: Model model_path_0 has different number of inputs/outputs
[       OK ] BulkPipelineManagerTest.test_verify_models (0 ms)
[----------] 4 tests from BulkPipelineManagerTest (0 ms total)

[----------] 4 tests from BulkPipelineModelTest
[ RUN      ] BulkPipelineModelTest.test_model_creation
[       OK ] BulkPipelineModelTest.test_model_creation (0 ms)
[ RUN      ] BulkPipelineModelTest.test_model_run
[       OK ] BulkPipelineModelTest.test_model_run (0 ms)
[ RUN      ] BulkPipelineModelTest.test_model_release
[       OK ] BulkPipelineModelTest.test_model_release (0 ms)
[ RUN      ] BulkPipelineModelTest.test_async_fill
Failed to fill buffers asynchronously: Buffers not properly initialized for: next_model_path
[       OK ] BulkPipelineModelTest.test_async_fill (0 ms)
[----------] 4 tests from BulkPipelineModelTest (0 ms total)

[----------] Global test environment tear-down
[==========] 11 tests from 3 test suites ran. (0 ms total)
[  PASSED  ] 11 tests.

@hseok-oh hseok-oh merged commit 3e341d1 into Samsung:master Feb 26, 2026
9 checks passed
@batcheu batcheu deleted the add_model_verification branch February 27, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants