[onert/cpu] Fix exception throw for unsupported data type#16428
Merged
hseok-oh merged 1 commit intoSamsung:masterfrom Mar 10, 2026
Merged
[onert/cpu] Fix exception throw for unsupported data type#16428hseok-oh merged 1 commit intoSamsung:masterfrom
hseok-oh merged 1 commit intoSamsung:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in ResizeBilinearLayer::run() where std::runtime_error was constructed without the throw keyword, meaning the exception was silently discarded and execution would fall through or continue incorrectly when encountering unsupported data types.
Changes:
- Added the missing
throwkeyword to thestd::runtime_errorin thedefaultcase of the data type switch. - Consolidated the previously separate "NYI" (not yet implemented) cases (
INT32,INT64,QUANT_INT8_SYMM) to fall through to thedefaultcase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit fixes a typo which results in the exception not being thrown. ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a typo which results in the exception not being thrown.