[DONOTMERGE] build: Pass OUTPUT_DIR as argument instead of hardcodi#7178
Open
ewoodev wants to merge 4 commits intoSamsung:masterfrom
Open
[DONOTMERGE] build: Pass OUTPUT_DIR as argument instead of hardcodi#7178ewoodev wants to merge 4 commits intoSamsung:masterfrom
ewoodev wants to merge 4 commits intoSamsung:masterfrom
Conversation
ewoodev
changed the title
Build scripts and tools previously used hardcoded paths or environment variables for the output directory (build/output), making it difficult to customize output locations and causing inconsistency across the build system. - Define OUTPUT_DIR in Makefile.unix and pass it to all sub-makes - mkbootparam.py, mksamsungheader.py, validate_output.py: require OUTPUT_DIR as mandatory argument - trap.py: require -o/--output-dir - mksmartfsimg.sh, g_var_profiler.sh: require OUTPUT_DIR as $1 or -d - dutils.sh: use fixed build/output (entry script, no user input) - Update build configs (bk7239n, rtl8720e, rtl8721csm, rtl8730e) to pass OUTPUT_DIR to mksamsungheader and mkbootparam
ewoodev
force-pushed
the
WORK-250226_output_dir_as_argument
branch
from
24af286 to
6bdd726
Compare
The post-build scripts (set_bininfo.py, convert_binary.py, check_package_size.py) previously processed all binaries at once, making it difficult to separate the build process for individual binary types (kernel, app, common, resource). - Refactor scripts to accept bin_type or binary name as argument - Add per-binary calls in PREPARE_APP macro for app/common binaries - Add individual calls for kernel and resource in post target - Remove check_package_size call from validate_output.py - Support both explicit bin_type (app1, kernel, etc.) and config binary name
The MEMSTATS variable was not set for armv7-a GNU_EABI toolchain, causing memory statistics generation to be skipped during build. - Add MEMSTATS = gnueabil for GNU_EABI toolchain configuration
The monolithic post target made it difficult to build individual components separately and increased build time when only specific outputs needed rebuilding. - post1: Build user binaries (app1, app2, common) - post2: Build kernel binary and related outputs (bootparam, uImage, etc.) - post3: Build filesystem images (resource, smartfs) - Update $(BIN) dependencies to call post1 post2 post3 directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build scripts and tools previously used hardcoded paths or environment variables for the output directory (build/output), making it difficult to customize output locations and causing inconsistency across the build system.