Support Unicode input #25
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output was already fine. So I think this is all that's needed to support Unicode. It is testable with
example/input.cr. I also used this example to test, that in the end I didn't include in the PR because it's so similar to the one there's already in the repository:Of course, it would be possible to add this method with a different name instead of replacing it, but I thought this would be ok because it's backwards compatible (obviously works with ASCII input) and it just makes sense in a language like Crystal that supports Unicode by default. Let me know if you think that having an additional
get_char_wor something like that would be better.This is the only method currently implemented that would need to change if I'm not mistaken. I thought of adding
wget_wstr, but sincewgettstris not implemented, I left it so.Fixes #13.