Skip to content

Issue #38. Fixed rounding errors. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kubsztal wants to merge 1 commit into from
Closed

Issue #38. Fixed rounding errors. #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion vcd/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,25 @@ def format_value(self, value: RealValue, check: bool = True) -> str:
:returns: string representing value change for use in a VCD stream.

"""

value_str = str(value).replace('E', 'e')

if 'e' in value_str:
mantissa, _ = value_str.split('e')
else:
mantissa = value_str

mantissa = mantissa.replace('-', '').replace('+', '').replace('.', '').strip('0')
significant_digits = 0

if mantissa:
significant_digits = len(mantissa)

if not check or isinstance(value, Number):
return f"r{value:.16g} {self.ident}"
if significant_digits > 16:
return f"r{value:.16g} {self.ident}"
else:
return f"r{value} {self.ident}"
else:
raise ValueError(f"Invalid real value ({value})")

Expand Down