Fix members named _ not being created in structs#1568
Merged
SanderMertens merged 2 commits intoSanderMertens:masterfrom Feb 18, 2025
Merged
Fix members named _ not being created in structs#1568SanderMertens merged 2 commits intoSanderMertens:masterfrom
_ not being created in structs#1568SanderMertens merged 2 commits intoSanderMertens:masterfrom
Conversation
Owner
|
Looks good to me! After you update distr/flecs.c as well CI should pass. |
Contributor
Author
|
Cool! I updated it manually this time, but for future reference, is there a way to update it automaticly from |
Owner
|
It will automatically update when you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I found with
ecs_struct_init. When attempting to initialize a struct with a member named_the member would silently not be created at all. The issue was that the method used to create the members,ecs_entity, would return the any entity instead of creating a new one. Swapping that method forecs_new_from_pathfixes the issue.