Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements extensive observability changes across the dataset metrics system, enhancing monitoring capabilities with new downtime tracking, time-series granularity support, and improved data lineage components.
Key Changes:
- Added hourly and daily granularity support for metrics queries with time period-based processing
- Replaced data quality metrics with downtime monitoring functionality using Kubernetes and Prometheus metrics
- Enhanced data lineage tracking with new extractor success/duplicate counts and dataset mode support
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| DatasetMetricsService.ts | Major refactor adding time-based granularity, downtime monitoring, enhanced connector metrics, and Prometheus integration |
| queries.ts | Updated query functions to support time period granularity and added new Prometheus-based queries for extractors and dedup operations |
| DatasetMetricsController.ts | Added date range validation, downtime category support, and replaced data quality with downtime metrics |
| DatasetMetrics.json | Updated schema to support date ranges and downtime monitoring parameters |
| DataObsrvDefaults.ts | New configuration file defining container components for downtime monitoring |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for retrieving connector-level metrics has been added.