Skip to content

Observability changes#366

Open
Shashankpgit wants to merge 26 commits intorelease-1.9.1from
observability-changes
Open

Observability changes#366
Shashankpgit wants to merge 26 commits intorelease-1.9.1from
observability-changes

Conversation

@Shashankpgit
Copy link

@Shashankpgit Shashankpgit commented Aug 28, 2025

The logic for retrieving connector-level metrics has been added.

@manjudr manjudr requested a review from Copilot August 28, 2025 13:16

This comment was marked as outdated.

Shashankpgit and others added 5 commits August 28, 2025 19:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@manjudr manjudr requested a review from Copilot August 29, 2025 05:19

This comment was marked as outdated.

@manjudr manjudr requested a review from Copilot August 29, 2025 05:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements extensive observability changes across the dataset metrics system, enhancing monitoring capabilities with new downtime tracking, time-series granularity support, and improved data lineage components.

Key Changes:

  • Added hourly and daily granularity support for metrics queries with time period-based processing
  • Replaced data quality metrics with downtime monitoring functionality using Kubernetes and Prometheus metrics
  • Enhanced data lineage tracking with new extractor success/duplicate counts and dataset mode support

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
DatasetMetricsService.ts Major refactor adding time-based granularity, downtime monitoring, enhanced connector metrics, and Prometheus integration
queries.ts Updated query functions to support time period granularity and added new Prometheus-based queries for extractors and dedup operations
DatasetMetricsController.ts Added date range validation, downtime category support, and replaced data quality with downtime metrics
DatasetMetrics.json Updated schema to support date ranges and downtime monitoring parameters
DataObsrvDefaults.ts New configuration file defining container components for downtime monitoring

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants