Skip to content

#OI-I3: Fix: added loggers for load status conditions during querying#368

Merged
manjudr merged 1 commit intomainfrom
api-svc-fixes
Dec 9, 2025
Merged

#OI-I3: Fix: added loggers for load status conditions during querying#368
manjudr merged 1 commit intomainfrom
api-svc-fixes

Conversation

@JeraldJF
Copy link
Collaborator

@JeraldJF JeraldJF commented Dec 9, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved error logging for data availability checks to provide clearer error messages in specific scenarios.
  • Chores

    • Code formatting improvements and minor normalization adjustments.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

Error-logging enhancements added to the DataOut QueryValidator module. Two new debug log statements were inserted in the checkSupervisorAvailability method to capture specific error conditions before throwing NOT_FOUND exceptions. Minor formatting adjustment applied to an existing throw statement.

Changes

Cohort / File(s) Summary
Error logging and formatting
api-service/src/controllers/DataOut/QueryValidator.ts
Added two error-logging lines in checkSupervisorAvailability when datasource availability is undefined or not 100%. Minor space normalization in existing throw statement in setDatasourceRef.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change with minimal impact
  • Error logging additions are straightforward and self-contained
  • Formatting change is cosmetic with no functional consequence

Poem

🐰 A rabbit hops through logs so bright,
Recording errors through the night,
With tiny tweaks and spaces squared,
The validators are well prepared!
thump thump

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding logger statements for load status conditions in the QueryValidator controller during data querying operations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch api-svc-fixes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d14a20b and 1188f94.

📒 Files selected for processing (1)
  • api-service/src/controllers/DataOut/QueryValidator.ts (2 hunks)
🔇 Additional comments (1)
api-service/src/controllers/DataOut/QueryValidator.ts (1)

221-223: Throw formatting and error code usage in setDatasourceRef look good

The obsrvError throw for the “dataset not available for querying” case now cleanly uses errCode.notFound with consistent formatting. This aligns with other usages in the file; no further changes needed here.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manjudr manjudr merged commit 337573a into main Dec 9, 2025
3 of 4 checks passed
@manjudr manjudr deleted the api-svc-fixes branch December 9, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants