more work on ifrit #1041
Open
more work on ifrit #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix selectors on CastAction - make eruption actually target the player (todo: figure out explosion is on self instead of target pos) - stop enemies moving during action casts - todo: figure out why eruption damages ifrit
- improve StateCombat movement code to better match retail
- todo: maybe store the value in a director var instead of TimelinePack
- move checkAction to processActions and run in Chara::update once per tick
- todo: sim knockback server side properly
- account for target radius in aoes (todo: cones, box) - add method to grab entity by id from Territory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix selectors on CastAction
make eruption actually target the player (todo: figure out explosion is on self instead of target pos)
stop enemies moving during action casts
todo: figure out why eruption damages ifrit