Conversation
Contributor
|
the gcd cases for p1 work fine for me. The expected results for p2 are still in the divmod format and therefore dont work |
Sarsum
force-pushed
the
03-fix-gcd-cases
branch
from
d0f17f2 to
23f7fa1
Compare
gfpoly_gcd and replace expectedResults accordingly
Sarsum
force-pushed
the
03-fix-gcd-cases
branch
from
23f7fa1 to
0dead70
Compare
Contributor
|
works now for both 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename gcd testcases action from gfpoly_divmod to gfpoly_gcd and replace ace expectedResults accordingly
@melo-afk / @niri81 quick check if the results are correct would be much appreciated