Skip to content

add generated cases for sff for p1 and p2#27

Closed
Sarsum wants to merge 1 commit intomainfrom
testcases-sff
Closed

add generated cases for sff for p1 and p2#27
Sarsum wants to merge 1 commit intomainfrom
testcases-sff

Conversation

@Sarsum
Copy link
Owner

@Sarsum Sarsum commented Nov 16, 2025

I think 1000 Cases each should be enough (keeping Python users in mind :P)

Testfile                               | Successful | Failed (C) | Missing (C) | Time Seconds | Failed (T) | Missing (T)
---------------------------------------+------------+------------+-------------+--------------+------------+------------
03_action_gfpoly_factor_sff_p1_01.json | 1000       | 0          | 0           | 1.060        | None       | None       
03_action_gfpoly_factor_sff_p2_01.json | 1000       | 0          | 0           | 0.647        | None       | None

@melo-afk
Copy link
Contributor

Works for me 👍

@Sarsum
Copy link
Owner Author

Sarsum commented Nov 17, 2025

I'll reduce the amount before merging

Copy link
Collaborator

@niri81 niri81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polynomials are not monic and do therefore not adhere to specification. Please fix

@Sarsum
Copy link
Owner Author

Sarsum commented Nov 22, 2025

Yeay I will push completely new cases. These are generated and I then used my SFF implementation.

The polynomials of the new cases are generated from smaller, coprime and square free polynomials which I then used to construct the expectedResults without using SFF

@Sarsum Sarsum closed this Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants