Changelog Checker in PRs Using GitHub Action#48
Open
athul-7735 wants to merge 15 commits intoSasanLabs:developfrom
Open
Changelog Checker in PRs Using GitHub Action#48athul-7735 wants to merge 15 commits intoSasanLabs:developfrom
athul-7735 wants to merge 15 commits intoSasanLabs:developfrom
Conversation
fix: Missing Rule Details - Ensure i18n always initialized
Addition of Incorrect Signature attack Co-authored-by: twelcon <mastermind12210@gmai.com> Co-authored-by: Karan Preet Singh Sasan <preetkaran20@gmail.com>
* Adds static file and 404 check Signed-off-by: karthikuj <karthikuj2001@gmail.com> * Updates CHANGELOG Signed-off-by: karthikuj <karthikuj2001@gmail.com> --------- Signed-off-by: karthikuj <karthikuj2001@gmail.com>
Adding debug config and upgrading spotless version
Collaborator
|
Please remove the unrelated commits. |
Author
|
Thanks for the feedback, @kingthorin . I will create another PR from another branch with only the necessary commits. |
athul-7735
force-pushed
the
change_log_action
branch
from
a7bfac8 to
80b4ebb
Compare
Collaborator
|
Just do an interactive rebase and skip all those that are unnecessary. The force push just the proper commit(s). |
Author
|
Hi @kingthorin I have pushed the changes after the rebase. |
Collaborator
|
There's still 12 commits and 15 files changed |
Member
|
Hi @athul-7735 , follow this guide for squashing commits into one commit: https://gist.github.com/patik/b8a9dc5cd356f9f6f980 |
Incorporating review comments fix: Missing Rule Details - Ensure i18n always initialized Related to SasanLabs/owasp-zap-fileupload-addon#17 Add CHANGELOG note Create FUNDING.yml Incorrect Signature attach added (SasanLabs#39) Addition of Incorrect Signature attack Co-authored-by: twelcon <mastermind12210@gmai.com> Co-authored-by: Karan Preet Singh Sasan <preetkaran20@gmail.com> Releasing newer version 1.0.3 (SasanLabs#40) Reduce JWT scan rules false positives (SasanLabs#43) * Adds static file and 404 check Signed-off-by: karthikuj <karthikuj2001@gmail.com> * Updates CHANGELOG Signed-off-by: karthikuj <karthikuj2001@gmail.com> --------- Signed-off-by: karthikuj <karthikuj2001@gmail.com> Update gradle.yml (SasanLabs#45) Adding debug config and upgrading spotless version (SasanLabs#44) Adding debug config and upgrading spotless version Update README.md Update README.md - Drop OWASP from ZAP refs (SasanLabs#46)
…sp-zap-jwt-addon into change_log_action
Author
|
I have tried squashing the commits into a single commit, but still getting all the commits and file changes in the PR. Raised another PR #49 with the relevant commits only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action to ensure CHANGELOG.md is updated before merging a PR. It prevents accidental merges without changelog updates and improves documentation consistency.
Key Changes:
Integrated Zomzog/changelog-checker@v1.2.0.
PRs fail if CHANGELOG.md is not modified.
Allows bypassing with the "no changelog" label.
Closes #18