Merged
Conversation
This time less intrusive, making it easier to work on this alongside the main branch Refs #871
Work-in-progress
Work-in-progress
Work-in-progress
# Conflicts: # examples/dynamicrenderingmultisampling/dynamicrenderingmultisampling.cpp
Closed
Reworked command buffer setup and fix sync
Reworked command buffer Sync needs some additional fixing
Implicitly handled via command pool flag
Except for semaphores related to presentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt to rework synchronization for all samples. The goal is to get rid of the vkQueueWaitIdle at the end of each frame and introduce frames-in-flight. This PR will also do away with pre-building command buffers.
Note: This is a Work-in-progress and far from finished. Even the samples that have been updated may exhibit issues as some parts of the framework (like the UI) haven't been adjusted yet.
Progress*:
*no guarantee that sync is 100% perfect