Reducing draw calls in textoverlay example#1231
Merged
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom Aug 28, 2025
Merged
Reducing draw calls in textoverlay example#1231SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
Conversation
Owner
|
Thanks for your PR. Your contribution is very much appreciated. As for further improvements: I want to keep this sample as simple as possible, it's kinda like a precursor to the ImGui sample. So I'm fine with the way it is (after this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if this pull request is denied, I'd still recommend changing line 107 to
VkDeviceSize bufferSize = TEXTOVERLAY_MAX_CHAR_COUNT * sizeof(glm::vec4) * 4;
or renaming TEXTOVERLAY_MAX_CHAR_COUNT to TEXTOVERLAY_MAX_VERTEX_COUNT
addText should have protections for vertexBuffer overflow (situations in which numLetters >= TEXTOVERLAY_MAX_CHAR_COUNT), but I'm assuming that's out of scope for this example.
there's still room for other easy optimizations.
like an index buffer,
or a separate buffer containing font data as a whole, reducing uploaded data and cpu calculations.