Skip to content

Reducing draw calls in textoverlay example#1231

Merged
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
GDBobby:patch-1
Aug 28, 2025
Merged

Reducing draw calls in textoverlay example#1231
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
GDBobby:patch-1

Conversation

@GDBobby
Copy link
Contributor

@GDBobby GDBobby commented Aug 15, 2025

if this pull request is denied, I'd still recommend changing line 107 to

VkDeviceSize bufferSize = TEXTOVERLAY_MAX_CHAR_COUNT * sizeof(glm::vec4) * 4;

or renaming TEXTOVERLAY_MAX_CHAR_COUNT to TEXTOVERLAY_MAX_VERTEX_COUNT

addText should have protections for vertexBuffer overflow (situations in which numLetters >= TEXTOVERLAY_MAX_CHAR_COUNT), but I'm assuming that's out of scope for this example.

there's still room for other easy optimizations.
like an index buffer,
or a separate buffer containing font data as a whole, reducing uploaded data and cpu calculations.

@SaschaWillems
Copy link
Owner

Thanks for your PR. Your contribution is very much appreciated.

As for further improvements: I want to keep this sample as simple as possible, it's kinda like a precursor to the ImGui sample. So I'm fine with the way it is (after this PR).

@SaschaWillems SaschaWillems merged commit 162c57d into SaschaWillems:master Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants