Skip to content

descriptorheap: fix image offset#1258

Merged
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
djdeath:review/dh-fix
Feb 16, 2026
Merged

descriptorheap: fix image offset#1258
SaschaWillems merged 1 commit intoSaschaWillems:masterfrom
djdeath:review/dh-fix

Conversation

@djdeath
Copy link
Copy Markdown
Contributor

@djdeath djdeath commented Feb 15, 2026

I noticed this while debugging why the demo doesn't render anything on Intel/Mesa.

There are 2 buffers and the code says the images are after the buffers.

@SaschaWillems
Copy link
Copy Markdown
Owner

Thank you very much for this PR!. This worked on my setup by accident, cause imageDescriptorAlignment is the same as uniformBuffers.size() * bufferDescriptorSize.

@SaschaWillems SaschaWillems merged commit 42b9496 into SaschaWillems:master Feb 16, 2026
3 checks passed
@spencer-lunarg
Copy link
Copy Markdown

... this is going to be the same bug 1000 people make, even with GPU-AV added, it will only help detect on the broken machine, might just be a documentation thing, not sure, but glad we fixed this here now since assume people will be using this example for time to come lol

@SaschaWillems
Copy link
Copy Markdown
Owner

Yeah, it's a common Vulkan problem that's a bit exaggerated here due to all the alignments, offsets, preserved sizes, etc. introduced in the heaps extension. I'm with you that this is something that can prob. only be mitigated by documentation. The guide chapter on heaps already helped me a lot with this sample, so maybe I can add some of my experience writing this sample to that chapter at some point.

@spencer-lunarg
Copy link
Copy Markdown

The guide chapter on heaps already helped me a lot with this sample, so maybe I can add some of my experience writing this sample to that chapter at some point.

Glad it helpped (I still re-reference it myself lol) ... anything you want to add to it you feel it "worth wild" that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants