Updated multiCV modal locator to support bulk update as well#2308
Merged
LadislavVasina1 merged 3 commits intoSatelliteQE:masterfrom Feb 11, 2026
Merged
Updated multiCV modal locator to support bulk update as well#2308LadislavVasina1 merged 3 commits intoSatelliteQE:masterfrom
LadislavVasina1 merged 3 commits intoSatelliteQE:masterfrom
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
manage_cvemethod signature was updated tolce_name/cv_namebut the docstring still refers tolce/cv; please align parameter names and descriptions so they match the implementation. - The XPath used for
save_btnandcancel_btninManageMultiCVEnvModalduplicates the sameor @data-ouia-component-id=...pattern; consider extracting a shared base locator or helper to avoid duplication and make future updates less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `manage_cve` method signature was updated to `lce_name`/`cv_name` but the docstring still refers to `lce`/`cv`; please align parameter names and descriptions so they match the implementation.
- The XPath used for `save_btn` and `cancel_btn` in `ManageMultiCVEnvModal` duplicates the same `or @data-ouia-component-id=...` pattern; consider extracting a shared base locator or helper to avoid duplication and make future updates less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
vijaysawant
requested changes
Feb 10, 2026
LadislavVasina1
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiCV bulk update
Manage content->Content view environmentsmodal/View has some different locator. To reuse same Modal/View that we used for activation key and host overview I have updated locators.Robotello PR:SatelliteQE/robottelo#20755