Skip to content

Updated multiCV modal locator to support bulk update as well#2308

Merged
LadislavVasina1 merged 3 commits intoSatelliteQE:masterfrom
jnagare-redhat:multi_cv_bulk_update
Feb 11, 2026
Merged

Updated multiCV modal locator to support bulk update as well#2308
LadislavVasina1 merged 3 commits intoSatelliteQE:masterfrom
jnagare-redhat:multi_cv_bulk_update

Conversation

@jnagare-redhat
Copy link
Contributor

@jnagare-redhat jnagare-redhat commented Feb 10, 2026

MultiCV bulk update Manage content->Content view environments modal/View has some different locator. To reuse same Modal/View that we used for activation key and host overview I have updated locators.
Robotello PR:SatelliteQE/robottelo#20755

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The manage_cve method signature was updated to lce_name/cv_name but the docstring still refers to lce/cv; please align parameter names and descriptions so they match the implementation.
  • The XPath used for save_btn and cancel_btn in ManageMultiCVEnvModal duplicates the same or @data-ouia-component-id=... pattern; consider extracting a shared base locator or helper to avoid duplication and make future updates less error-prone.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `manage_cve` method signature was updated to `lce_name`/`cv_name` but the docstring still refers to `lce`/`cv`; please align parameter names and descriptions so they match the implementation.
- The XPath used for `save_btn` and `cancel_btn` in `ManageMultiCVEnvModal` duplicates the same `or @data-ouia-component-id=...` pattern; consider extracting a shared base locator or helper to avoid duplication and make future updates less error-prone.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LadislavVasina1 LadislavVasina1 merged commit 5ef7ec7 into SatelliteQE:master Feb 11, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants