Conversation
* Fix ruff linting issues to prepare for version bump - Add __hash__ method to Entity class (PLW1641) - Fix dictionary iteration to use .items() (PLC0206) - Add noqa comments for intentional mid-function imports (PLC0415) All tests pass and ruff linting now succeeds with no errors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply pre-commit automated fixes - Black formatting for nailgun/entities.py - Ruff removed unnecessary noqa comments (PLC0415 no longer flagged) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Update nailgun/entity_mixins.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 4c2716f)
Satellite-QE
added
6.17.z
Auto_Cherry_Picked
Satellite-QE
added
the
AutoMerge_Cherry_Picked
ogajduse
deleted the
cherry-pick-6.17.z-4c2716f5aa1b119fcc7245393cb3dabb692ee506
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #1328
Summary
__hash__method to Entity class.items()for dictionary iteration instead of iterating over keysTest plan
ruff checkpasses with no errorsmake testsucceedspre-commit run -apasses all hooks (black, ruff, check yaml, debug statements)This PR prepares the codebase for upcoming ruff version bump #1253 by addressing current linting issues while maintaining backward compatibility and test functionality. All pre-commit hooks now pass successfully.
🤖 Generated with Claude Code