[6.19.z] [PR] Allow to query config reports#1411
Merged
adamlazik1 merged 1 commit into6.19.zfrom Mar 18, 2026
Merged
Conversation
- New class for reading API endpoint config_reports - Entities are deletable, readable and searchable Note: The JSON response contains host_name unlike host in the response of the legacy reports API. Co-authored-by: Jan Bundesmann <bundesmann@atix.de> (cherry picked from commit abf8d86)
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The docstring for
ConfigReportstill references a genericReportentity; consider updating it to accurately describe the config report representation and its purpose. - Review whether
ConfigReportshould expose common identifying fields (e.g., anidfield) consistent with other entity classes in this module, to make searching and handling results more uniform.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The docstring for `ConfigReport` still references a generic `Report` entity; consider updating it to accurately describe the config report representation and its purpose.
- Review whether `ConfigReport` should expose common identifying fields (e.g., an `id` field) consistent with other entity classes in this module, to make searching and handling results more uniform.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
adamlazik1
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #1407
Description of changes
Enable querying the API endpoint for config reports.