Add possibility to specify download-utility

[dosas]

Problem Statement

newly added download utility option missing theforeman/foreman#9808

Solution

Add field

Related Issues

dependency SatelliteQE/nailgun#1257

[Satellite-QE]

Can one of the admins verify this patch?

[Gauravtalreja1]

@dosas Do you intent to add some test to cover this option?

[dosas]

Obviously I did not intent to ;) but if you point me in the right direction I can add a test.

[Gauravtalreja1]

Sure, this tests can be added to any of tests/foreman/{api,cli,ui}/test_registration.py, and you can check of any e2e marked tests present in this modules for reference.

[dosas]

@Gauravtalreja1 I thought you were talking about a test in tests/robottelo ...

I doubt that we can add a meaningful e2e test for this on rhel operating systems because this option was specifically added for debian based operating systems where instead of curl wget is installed on default.

Or are you talking about a test where we just set the option explicitly to curl?

[Gauravtalreja1]

@dosas yes, I get that, but I meant like we've option to install wget first on rhel/centos as part of test setup, then running a registration command with download_utility=wget

[dosas]

@Gauravtalreja1 I have added a test but I have no idea how (and where in the setup) I can install a package on an unregistered contenthost? Could you give me a hint?

Also which ID should I use for the new test?

[ogajduse]

@dosas For the test ID: simply generate a new UUID. See https://github.com/SatelliteQE/robottelo/wiki/Robottelo-Contributing-Guidelines#required-docstring-content

To ensure the content is already on the host:

1. ensure that the host already has required tooling installed or
2. Write a fixture, register the host, enable repositories if needed, install tooling, unregister the host.

Our hosts already have both tools installed, however I do not like the fact that they come with pre-installed, non-default packages. In my view, robottelo should assume a host with a minimal installation. By minimal installation, I mean either the Minimal Install or Core package groups (dnf group info "Core"). I would prefer going with 2., however it is not ideal to register twice per test.

[dosas]

@ogajduse I fixed the uuid.

If we go with option 1. it should already be possible to run the PRT on this test?

tests/foreman/cli/test_registration.py::test_positive_register_download_utility

would you mind triggering it?

[Satellite-QE]

PRT Result

Build Number: 10556
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_registration.py::test_positive_register_download_utility --external-logging
Test Result: ================== 8 warnings, 2 errors in 6856.76s (1:54:16) ==================

[Satellite-QE]

PRT Result

Build Number: 10565
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_registration.py::test_positive_register_download_utility --external-logging
Test Result: ================= 2 passed, 106 warnings in 1358.30s (0:22:38) =================

[ogajduse]

Thank you, @dosas. Let's get it in.