Add test coverage for SAT-28860 by Gauravtalreja1 · Pull Request #17153 · SatelliteQE/robottelo

Gauravtalreja1 · 2024-12-11T21:53:33Z

Problem Statement

Missing test coverage for new feature SAT-28860

Solution

Add test coverage for new feature SAT-28860

Related Issues

SatelliteQE/airgun#1636
SatelliteQE/nailgun#1254

Gauravtalreja1 · 2024-12-11T22:00:47Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy

Satellite-QE · 2024-12-11T22:42:30Z

PRT Result

Build Number: 9595
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 60 warnings, 5 errors in 1723.27s (0:28:43) =============

Gauravtalreja1 · 2024-12-11T23:01:20Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2024-12-11T23:40:51Z

PRT Result

Build Number: 9596
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 94 warnings, 5 errors in 1960.40s (0:32:40) =============

vsedmik · 2024-12-20T10:01:22Z

PRT failed in http_proxy = target_sat.api_factory.make_http_proxy()
with

00:40:38  >               setattr(entity, field_name, attrs[field_name])
00:40:38  E               KeyError: 'default_content_http_proxy'

See SatelliteQE/nailgun#1254 (comment)

Gauravtalreja1 · 2024-12-20T14:41:24Z

@vsedmik yes, it'll be fixed in Katello/katello#11266

Gauravtalreja1 · 2025-01-10T21:48:24Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-01-11T00:09:22Z

PRT Result

Build Number: 9826
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 499 warnings, 5 errors in 7913.30s (2:11:53) ============

vsedmik · 2025-01-14T09:11:25Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636
Katello:
    katello: 11266

Satellite-QE · 2025-01-14T10:53:32Z

PRT Result

Build Number: 9849
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 69 warnings, 5 errors in 5724.06s (1:35:24) =============

Gauravtalreja1 · 2025-01-27T18:31:04Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-01-27T18:54:51Z

PRT Result

Build Number: 9994
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 69 warnings, 5 errors in 1019.88s (0:16:59) =============

Gauravtalreja1 · 2025-01-28T13:16:31Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-01-28T13:39:41Z

PRT Result

Build Number: 9997
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 62 warnings, 5 errors in 1014.08s (0:16:54) =============

Gauravtalreja1 · 2025-01-28T13:40:55Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-01-28T14:05:59Z

PRT Result

Build Number: 10000
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ============ 1 failed, 60 warnings, 5 errors in 1073.28s (0:17:53) =============

Gauravtalreja1 · 2025-02-13T08:27:56Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-02-13T09:15:00Z

PRT Result

Build Number: 10159
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ======= 3 failed, 2 passed, 251 warnings, 5 errors in 2235.48s (0:37:15) =======

Gauravtalreja1 · 2025-02-13T11:52:03Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy
nailgun: 1254
airgun: 1636

Satellite-QE · 2025-02-13T12:34:21Z

PRT Result

Build Number: 10167
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy tests/foreman/ui/test_http_proxy.py::test_positive_set_default_http_proxy --external-logging
Test Result : ======= 2 failed, 3 passed, 260 warnings, 2 errors in 1906.10s (0:31:46) =======

Gauravtalreja1 · 2025-02-13T13:05:10Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy
nailgun: 1254

Satellite-QE · 2025-02-13T13:42:57Z

PRT Result

Build Number: 10169
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy --external-logging
Test Result : ======= 2 failed, 2 passed, 245 warnings, 2 errors in 1819.81s (0:30:19) =======

tests/foreman/ui/test_http_proxy.py

Gauravtalreja1 · 2025-02-14T13:50:42Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy
nailgun: 1254

Satellite-QE · 2025-02-14T14:30:31Z

PRT Result

Build Number: 10182
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy --external-logging
Test Result : ======= 3 failed, 2 passed, 288 warnings, 1 error in 1970.14s (0:32:50) ========

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Gauravtalreja1 · 2025-02-14T15:26:45Z

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy
nailgun: 1254

Satellite-QE · 2025-02-14T16:04:35Z

PRT Result

Build Number: 10183
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_http_proxy.py::test_positive_end_to_end tests/foreman/api/test_http_proxy.py::test_positive_install_content_with_http_proxy --external-logging
Test Result : ============ 3 failed, 2 passed, 285 warnings in 1893.06s (0:31:33) ============

Gauravtalreja1 · 2025-02-14T17:14:55Z

The remaining PRT failures are unrelated to the changes, so this PR is now RFR

robottelo/host_helpers/api_factory.py

shweta83

Ack.

jameerpathan111 · 2025-02-17T15:23:09Z

tests/foreman/ui/test_http_proxy.py

+            default_proxy = target_sat.api.Setting().search(
+                query={'search': 'name=content_default_http_proxy'}
+            )[0]
+            assert default_proxy.value != http_proxy_name


It's not a good practice to do assertions in teardown. Can we handle assertions in the test and keep the cleanup part separate? The results are misleading when debugging failures.

I don't think so it'll mislead us while debugging any failures, instead I think teardowns are best to ensure the Satellite we're using is in the same state as it was before, and adding assertions there, ensures everything worked in setup and teardown

vsedmik

Overall looks good, just one question I would like to clear out.

vsedmik · 2025-02-17T16:51:00Z

robottelo/host_helpers/api_factory.py

                username=settings.http_proxy.username,
                password=settings.http_proxy.password,
                organization=[org.id],
+                content_default_http_proxy=True,


I'm not sure if we want to always do this on proxy create via api_factory.make_http_proxy(), this fixture never done this before since that option is new. What is the reason to do so now?

@vsedmik Yes, the fixture behaviour is still same, if we make it non-default then we had to configure the setting explicitely and that step we have removed it from this setup fixture, and this new option configures the setting on create

Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 11, 2024

Gauravtalreja1 self-assigned this Dec 11, 2024

Gauravtalreja1 requested a review from a team December 11, 2024 21:53

Gauravtalreja1 requested a review from a team as a code owner December 11, 2024 21:53

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 11, 2024

Gauravtalreja1 marked this pull request as draft December 17, 2024 15:12

Gauravtalreja1 force-pushed the default-content-proxy branch from 66dd68e to c904a05 Compare January 10, 2025 21:47

Gauravtalreja1 marked this pull request as ready for review January 10, 2025 21:48

Gauravtalreja1 force-pushed the default-content-proxy branch from c904a05 to 9c69b44 Compare January 27, 2025 18:30

Gauravtalreja1 force-pushed the default-content-proxy branch from 9c69b44 to 18a5dd0 Compare January 28, 2025 13:40

Gauravtalreja1 force-pushed the default-content-proxy branch from 18a5dd0 to e25e798 Compare February 13, 2025 08:27

Gauravtalreja1 force-pushed the default-content-proxy branch from e25e798 to e8933f5 Compare February 13, 2025 10:34

Gauravtalreja1 mentioned this pull request Feb 14, 2025

Add locator for content_default_http_proxy checkbox on HTTP proxy create page SatelliteQE/airgun#1636

Merged

shweta83 reviewed Feb 14, 2025

View reviewed changes

tests/foreman/ui/test_http_proxy.py Show resolved Hide resolved

shweta83 reviewed Feb 14, 2025

View reviewed changes

tests/foreman/ui/test_http_proxy.py Show resolved Hide resolved

Gauravtalreja1 force-pushed the default-content-proxy branch from e8933f5 to 0f787ae Compare February 14, 2025 13:49

Gauravtalreja1 added 2 commits February 14, 2025 20:55

Add test coverage for SAT-28860

c62e3a4

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Update default proxy parameter to content_default_http_proxy

c72446b

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>

Gauravtalreja1 force-pushed the default-content-proxy branch from 0f787ae to c72446b Compare February 14, 2025 15:25

shweta83 reviewed Feb 17, 2025

View reviewed changes

robottelo/host_helpers/api_factory.py Show resolved Hide resolved

shweta83 approved these changes Feb 17, 2025

View reviewed changes

jameerpathan111 reviewed Feb 17, 2025

View reviewed changes

vsedmik reviewed Feb 17, 2025

View reviewed changes

jameerpathan111 approved these changes Feb 18, 2025

View reviewed changes

jameerpathan111 merged commit de7a385 into SatelliteQE:master Feb 18, 2025
9 of 10 checks passed

Gauravtalreja1 deleted the default-content-proxy branch February 18, 2025 07:00

Gauravtalreja1 mentioned this pull request Feb 18, 2025

Add issue SAT-5118 to test_positive_set_default_http_proxy #17629

Merged

vsedmik mentioned this pull request Feb 28, 2025

Use k-h-t from client repo for http proxy testing #17714

Merged

Conversation

Gauravtalreja1 commented Dec 11, 2024

Problem Statement

Solution

Related Issues

Uh oh!

Gauravtalreja1 commented Dec 11, 2024

Uh oh!

Satellite-QE commented Dec 11, 2024

Uh oh!

Gauravtalreja1 commented Dec 11, 2024

Uh oh!

Satellite-QE commented Dec 11, 2024

Uh oh!

vsedmik commented Dec 20, 2024

Uh oh!

Gauravtalreja1 commented Dec 20, 2024

Uh oh!

Gauravtalreja1 commented Jan 10, 2025

Uh oh!

Satellite-QE commented Jan 11, 2025

Uh oh!

vsedmik commented Jan 14, 2025

Uh oh!

Satellite-QE commented Jan 14, 2025

Uh oh!

Gauravtalreja1 commented Jan 27, 2025

Uh oh!

Satellite-QE commented Jan 27, 2025

Uh oh!

Gauravtalreja1 commented Jan 28, 2025

Uh oh!

Satellite-QE commented Jan 28, 2025

Uh oh!

Gauravtalreja1 commented Jan 28, 2025

Uh oh!

Satellite-QE commented Jan 28, 2025

Uh oh!

Gauravtalreja1 commented Feb 13, 2025

Uh oh!

Satellite-QE commented Feb 13, 2025

Uh oh!

Gauravtalreja1 commented Feb 13, 2025

Uh oh!

Satellite-QE commented Feb 13, 2025

Uh oh!

Gauravtalreja1 commented Feb 13, 2025

Uh oh!

Satellite-QE commented Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!

Gauravtalreja1 commented Feb 14, 2025

Uh oh!

Satellite-QE commented Feb 14, 2025

Uh oh!

Gauravtalreja1 commented Feb 14, 2025

Uh oh!

Satellite-QE commented Feb 14, 2025

Uh oh!

Gauravtalreja1 commented Feb 14, 2025

Uh oh!

Uh oh!

shweta83 left a comment

Choose a reason for hiding this comment

Uh oh!

jameerpathan111 Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

Gauravtalreja1 Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

vsedmik left a comment

Choose a reason for hiding this comment

Uh oh!

vsedmik Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

Gauravtalreja1 Feb 17, 2025

Choose a reason for hiding this comment