Tests for Satellite with local Insights Advisor

[tpapaioa]

Problem Statement

Need to add testing for Satellite w/ local Insights advisor engine.

Solution

• Create new pytest fixture, module_target_sat_insights. By default, or if it is parametrized with a True value, it will yield module_target_sat, which is configured to use hosted Insights to upload client data to Inventory and syncs recommendations from advisor. If the fixture is parametrized with a False value, then it will deploy a new Satellite and configure it to use the local advisor engine. Note: this requires some additional steps, to add the advisor rules to the engine once it's installed. These steps can be added to the new settings.rh_cloud.iop_setup_script settings, e.g.,

rh_cloud:
  iop_advisor_image: ''
  iop_setup_script: |
    git clone RULES_REPO
    cd iop-advisor-engine-content/ && ./generate_static.sh && mv static/ /etc/iop-advisor-engine/
    sed -i "/FOREMAN_URL/aEnvironment = RULES_COMPONENTS='telemetry.rules.plugins,prodsec.rules'" /etc/containers/systemd/iop-advisor-engine.container
    sed -i "/FOREMAN_URL/aVolume = /etc/iop-advisor-engine/static:/opt/app-root/src/static:z" /etc/containers/systemd/iop-advisor-engine.container
    systemctl daemon-reload
    systemctl restart iop-advisor-engine.service

See SAT-30174 for further details.

• Update the other fixtures in pytest_fixtures/component/rh_cloud.py to use module_target_sat_insights.
• Parametrize the existing advisor-related UI tests to use the new fixture, parametrized to run for both hosted and local Insights. Update the tests so that inventory and recommendations sync are performed only when the Satellite uses hosted Insights.
• Add test_rhcloud_inventory_disabled_local_insights test to verify that the Inventory Upload page is disabled when the local advisor engine is enabled. Because the other inventory tests are relevant only for hosted Insights, I haven't modified them, and they continue to use the module_target_sat fixture.
• Add local_advisor_engine_enabled property method to the Satellite class, to read the Satellite API and return a boolean indicating whether the local advisor is enabled (True) or not (False).

Related Issues

SAT-30174

PRT

See PRT result below.

[Satellite-QE]

PRT Result

Build Number: 10244
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_rhcloud_insights.py tests/foreman/ui/test_rhcloud_inventory.py -k local or hosted --external-logging
Test Result: ======== 21 passed, 26 deselected, 2071 warnings in 11853.04s (3:17:33) ========

[Satellite-QE]

PRT Result

Build Number: 10347
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_rhcloud_insights.py tests/foreman/ui/test_rhcloud_inventory.py -k hosted or local 
Test Result: ======== 21 passed, 26 deselected, 2178 warnings in 12562.14s (3:29:22) ========

[ColeHiggins2]

Looks good to me!

[ColeHiggins2]

@jeremylenz Mind taking a look as well?

[jeremylenz]

LGTM, just one wording suggestion below