Skip to content

Cover SAT-36783 in cockpit test#19526

Merged
LadislavVasina1 merged 1 commit intoSatelliteQE:masterfrom
adamruzicka:push-zwklzoslxlov
Sep 16, 2025
Merged

Cover SAT-36783 in cockpit test#19526
LadislavVasina1 merged 1 commit intoSatelliteQE:masterfrom
adamruzicka:push-zwklzoslxlov

Conversation

@adamruzicka
Copy link
Copy Markdown
Contributor

@adamruzicka adamruzicka commented Sep 15, 2025

Problem Statement

SAT-36783 states that remote execution cockpit integration fails if wide characters are present anywhere in the communication. This can typically happen in passwords. This PR extends the existing cockpit test to cover this situation.

Solution

Set a password on the test host as a parameter. Its value should get propagated to the communication, making the test fail until the bug is resolved.

Related Issues

https://issues.redhat.com/browse/SAT-36783
Companion to theforeman/foreman_remote_execution#1004

@adamruzicka adamruzicka requested a review from a team as a code owner September 15, 2025 07:21
@adamruzicka adamruzicka added the No-CherryPick PR doesnt need CherryPick to previous branches label Sep 15, 2025
@adamruzicka adamruzicka requested a review from a team as a code owner September 15, 2025 07:30
@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: tests/foreman/destructive/test_host.py

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k 'test_positive_cockpit[rhel9]'

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9]

@LadislavVasina1 LadislavVasina1 added the Stream Introduced in or relating directly to Satellite Stream/Master label Sep 15, 2025
@Satellite-QE
Copy link
Copy Markdown
Collaborator

Satellite-QE commented Sep 15, 2025

PRT Result

Build Number: 12658
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_host.py --external-logging
Test Result : ============ 4 failed, 773 warnings, 4 errors in 4965.88s (1:22:45) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 15, 2025
@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

Does this PR need to be cherry-picked to other branches?

Currently there are no plans to backport the fix, so no.

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4]

@Satellite-QE
Copy link
Copy Markdown
Collaborator

Satellite-QE commented Sep 15, 2025

PRT Result

Build Number: 12663
Build Status: UNSTABLE
PRT Comment: pytest -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4] --external-logging
Test Result : ========== 1 failed, 7 deselected, 16 warnings in 1963.19s (0:32:43) ===========

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4]

Well, third time's the charm

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4]

@Satellite-QE
Copy link
Copy Markdown
Collaborator

Satellite-QE commented Sep 15, 2025

PRT Result

Build Number: 12666
Build Status: UNSTABLE
PRT Comment: pytest -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4] --external-logging
Test Result : ========== 1 failed, 7 deselected, 17 warnings in 2016.53s (0:33:36) ===========

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

Good, this is the failure I was hoping for

@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 15, 2025

trigger: test-robottelo
pytest: -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4]
theforeman:
foreman_remote_execution: 1004

@Satellite-QE
Copy link
Copy Markdown
Collaborator

Satellite-QE commented Sep 15, 2025

PRT Result

Build Number: 12667
Build Status: SUCCESS
PRT Comment: pytest -v tests/foreman/destructive/test_host.py -k test_positive_cockpit[rhel9-ipv4] --external-logging
Test Result : ========== 1 passed, 7 deselected, 17 warnings in 2557.05s (0:42:37) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 15, 2025
@LadislavVasina1
Copy link
Copy Markdown
Contributor

LadislavVasina1 commented Sep 15, 2025 •
edited
Loading

@adamruzicka could you please remove uv.lock file.

@LadislavVasina1 LadislavVasina1 self-requested a review September 16, 2025 08:35
@adamruzicka
Copy link
Copy Markdown
Contributor Author

adamruzicka commented Sep 16, 2025

Eh, yeah, sorry about that

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 16, 2025
@LadislavVasina1 LadislavVasina1 removed the request for review from a team September 16, 2025 12:09
@LadislavVasina1 LadislavVasina1 merged commit d160568 into SatelliteQE:master Sep 16, 2025
10 checks passed
@adamruzicka adamruzicka deleted the push-zwklzoslxlov branch September 16, 2025 12:11
@adamruzicka adamruzicka added CherryPick PR needs CherryPick to previous branches 6.18.z Introduced in or relating directly to Satellite 6.18 and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 17, 2025
adamruzicka added a commit to adamruzicka/robottelo that referenced this pull request Sep 17, 2025
@adamruzicka
Cover SAT-36783 in cockpit test (SatelliteQE#19526)
d8b2438 
(cherry picked from commit d160568)
@adamruzicka adamruzicka mentioned this pull request Sep 17, 2025
Merged
adamruzicka added a commit to adamruzicka/robottelo that referenced this pull request Sep 17, 2025
@adamruzicka
Cover SAT-36783 in cockpit test (SatelliteQE#19526)
8730e35 
(cherry picked from commit d160568)
LadislavVasina1 pushed a commit that referenced this pull request Sep 19, 2025
@adamruzicka
[6.18.z] Cover SAT-36783 in cockpit test (#19526) (#19569)
944ccac 
Cover SAT-36783 in cockpit test (#19526)

(cherry picked from commit d160568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@adamruzicka adamruzicka

Labels

6.18.z Introduced in or relating directly to Satellite 6.18 CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamruzicka @Satellite-QE @LadislavVasina1