Add CSS variables for cell height

[davitykale-zz]

Necessary for Shadow DOM

---

This change is

[Saulis]

Hi and thanks! Would it be more useful if we add mixins for the cells instead? What do you think?

[davitykale-zz]

Sure! Either sounds good to me :)

On Wed, Nov 2, 2016 at 2:40 AM Sauli Tähkäpää [email protected]
wrote:

Hi and thanks! Would it be more useful if we add mixins for the cells
instead? What do you think?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#165 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEjMpE-BZBKY50WWKDmWNSr6bOXYDEUkks5q6FqkgaJpZM4Klq4E
.

[Saulis]

Hi!

Sorry for the delay! Now that I actually looked more into this matter, what's actually the use case this? As you can currently just normally style:

iron-data-table data-table-cell {
  height: 100px;
}

---

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[Storyyeller]

That doesn't work with the shadow dom.

[Storyyeller]

But #147 is more general, so I think you should go with that instead.

[Storyyeller]

In retrospect, I think this is useful independently of #147, since height has to be applied to both the checkbox and the cell, and we probably don't want the same mixin to apply to cell and checkbox.

Of course, that would require this to be modified to add the variables to checkbox as well.