Skip to content

Fix distributed child nodes side effects #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix distributed child nodes side effects #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 29 additions & 27 deletions iron-data-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,33 +477,35 @@
'_resetData(dataSource, filter.*, sortOrder.*)'
],

created: function() {
this._observer = Polymer.dom(this).observeNodes(function(info) {
var hasColumns = function(node) {
return (node.nodeType === Node.ELEMENT_NODE && node.tagName.toUpperCase() === 'DATA-TABLE-COLUMN');
};

var hasDetails = function(node) {
return (node.nodeType === Node.ELEMENT_NODE &&
node.tagName.toUpperCase() === 'TEMPLATE' && node.hasAttribute('is') &&
node.getAttribute('is') === 'row-detail');
};

if (info.addedNodes.filter(hasColumns).length > 0 ||
info.removedNodes.filter(hasColumns).length > 0) {
this.set('columns', this.getContentChildren('[select=data-table-column]'));
this.notifyResize();
}

if (info.addedNodes.filter(hasDetails).length > 0) {
this.set('rowDetail', this.getContentChildren('[select="template[is=row-detail]"]')[0]);

// assuming parent element is always a Polymer element.
// set dataHost to the same context the template was declared in
var parent = Polymer.dom(this.rowDetail).parentNode;
this.rowDetail._rootDataHost = parent.dataHost ? (parent.dataHost._rootDataHost || parent.dataHost) : parent;
}

attached: function() {
this.async(function(){
this._observer = Polymer.dom(this).observeNodes(function(info) {
var hasColumns = function(node) {
return (node.nodeType === Node.ELEMENT_NODE && node.tagName.toUpperCase() === 'DATA-TABLE-COLUMN');
};

var hasDetails = function(node) {
return (node.nodeType === Node.ELEMENT_NODE &&
node.tagName.toUpperCase() === 'TEMPLATE' && node.hasAttribute('is') &&
node.getAttribute('is') === 'row-detail');
};

if (info.addedNodes.filter(hasColumns).length > 0 ||
info.removedNodes.filter(hasColumns).length > 0) {
this.set('columns', this.getContentChildren('[select=data-table-column]'));
this.notifyResize();
}

if (info.addedNodes.filter(hasDetails).length > 0) {
this.set('rowDetail', this.getContentChildren('[select="template[is=row-detail]"]')[0]);

// assuming parent element is always a Polymer element.
// set dataHost to the same context the template was declared in
var parent = Polymer.dom(this.rowDetail).parentNode;
this.rowDetail._rootDataHost = parent.dataHost ? (parent.dataHost._rootDataHost || parent.dataHost) : parent;
}

}.bind(this));
}.bind(this));
},

Expand Down