Skip to content

Fixed Closure compilation error: invalid param name "detail.item" #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Closure compilation error: invalid param name "detail.item" #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions iron-data-table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,47 +978,47 @@
*
* @event selecting-item
* @param {Object} detail
* @param {Object} detail.item item to be selected
* @param {Object} item The item to be selected.
*/

/**
* Fired when user clicks on a item to deselect it.
*
* @event deselecting-item
* @param {Object} detail
* @param {Object} detail.item item to be deselected
* @param {Object} item The item to be deselected.
*/

/**
* Fired when user clicks on the select all checkbox to select items.
*
* @event selecting-all-items
* @param {Object} detail
* @param {Object} detail.items currently selected items
* @param {Object} items Currently selected items.
*/

/**
* Fired when user clicks on the select all checkbox to deselect items.
*
* @event deselecting-all-items
* @param {Object} detail
* @param {Object} detail.items currently selected items
* @param {Object} items Currently selected items.
*/

/**
* Fired when user clicks on a item to expand it.
*
* @event expanding-item
* @param {Object} detail
* @param {Object} detail.item item to be expanded
* @param {Object} item The item to be expanded.
*/

/**
* Fired when user clicks on a item to collapse it.
*
* @event collapsing-item
* @param {Object} detail
* @param {Object} detail.item item to be collapsed
* @param {Object} item The item to be collapsed.
*/

// we need to listen to click instead of tap because on mobile safari, the
Expand Down