Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Conversation

@nguyentoanit
Copy link
Contributor

No description provided.

@nguyentoanit
Copy link
Contributor Author

@moltar :
In reality, I think it will not occur these cases (on line 110 and 121).

Axios parses the response based on the HTTP response's Content-Type header. Therefore, data will either json object or empty string.

How do you think?

Ref:

@moltar
Copy link
Contributor

moltar commented Jan 15, 2021

I think I am not understanding the intent here. Feels like we are maybe putting too much faith into Amazon returning correct headers and data.

I've seen on the SP API where they return an error with 200 status. :)

Ping me on Slack when you have a minute, let's go over this live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants