feat(dbdr/net-peering) [STORY-3557] Add commands to configure net peerings of DB-DR#1208
Draft
leo-scalingo wants to merge 1 commit intomasterfrom
Draft
feat(dbdr/net-peering) [STORY-3557] Add commands to configure net peerings of DB-DR#1208leo-scalingo wants to merge 1 commit intomasterfrom
leo-scalingo wants to merge 1 commit intomasterfrom
Conversation
Member
leo-scalingo
commented
Mar 26, 2026
leo-scalingo
commented
- Add a changelog entry in the section "To Be Released" of CHANGELOG.md
leo-scalingo
force-pushed
the
feat/STORY-3557/db-dr-net-peering
branch
from
55bd16b to
0450112
Compare
| fmt.Println(io.Indent(err.Error(), 7)) | ||
| } | ||
|
|
||
| case http.StatusConflict: // 409 |
Contributor
There was a problem hiding this comment.
question: do we want to also handle debug here? (like for 404)
| require ( | ||
| github.com/AlecAivazis/survey/v2 v2.3.7 | ||
| github.com/Scalingo/go-scalingo/v11 v11.0.0 | ||
| github.com/Scalingo/go-scalingo/v11 v11.0.1-0.20260324141225-65ad50946664 |
Contributor
There was a problem hiding this comment.
note: this shouldn't be merged as is a should use a go-scalingo release.
|
|
||
| ## To Be Released | ||
|
|
||
| * feat(dbdr/net-peering) [STORY-3557] Add commands to configure net peerings of DB-DR |
Contributor
There was a problem hiding this comment.
nitpick: most of the time we are not mentioning story number on the public changelog.
| _ = t.Bulk([][]string{ | ||
| {"Outscale account ID", networkConfiguration.OutscaleAccountID}, | ||
| {"Outscale net ID", networkConfiguration.OutscaleNetID}, | ||
| {"IP range", networkConfiguration.IPRange}, |
Contributor
There was a problem hiding this comment.
question: no need for the OutscaleSourceAccountID like for the list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.