-
Notifications
You must be signed in to change notification settings - Fork 80
fix(redis-haproxy): add warning about HAProxy connection limit #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(redis-haproxy): add warning about HAProxy connection limit #3476
Conversation
To me, the whole "Scalingo for Caching" section should be reworked following the same structure as the one used for PG, MySQL or OpenSearch. ... But that would mean reworking the whole section, which is probably not a priority right now. For now, I would add a |
|
Good call — I added a |
Frzk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks and it's OK for me :)
Thanks a lot <3
| {% warning %} | ||
| When using a Business plan, the HAProxy instances serving as entry points to your cluster have a default limit of **2,000 concurrent TCP connections**. | ||
|
|
||
| If this limit is reached, any new connection will be abruptly refused. | ||
|
|
||
| This can result in "Connection timed out" errors such as: | ||
|
|
||
| - _Redis::CannotConnectError : Connection timed out_ | ||
| {% endwarning %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the warning block:
| {% warning %} | |
| When using a Business plan, the HAProxy instances serving as entry points to your cluster have a default limit of **2,000 concurrent TCP connections**. | |
| If this limit is reached, any new connection will be abruptly refused. | |
| This can result in "Connection timed out" errors such as: | |
| - _Redis::CannotConnectError : Connection timed out_ | |
| {% endwarning %} | |
| When using a Business plan, the HAProxy instances serving as entry points to your cluster have a default limit of **2,000 concurrent TCP connections**. | |
| If this limit is reached, any new connection will be abruptly refused. This can result in errors such as: | |
| ```shell | |
| Redis::CannotConnectError : Connection timed out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW. I haven't pushed any changes... I'm looking for your opinion first!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminach: I'm wondering if the notice is still mandatory... Any thoughts about it?


Fixes #3391
Question: I am not sure this is the right part of the document to add this. Where do you think is best?