Conversation
…ation.Request` in argument
EtienneM
force-pushed
the
fix/cli/1147/private_networks_pagination
branch
from
a1cb63f to
5accba7
Compare
EtienneM
commented
Mar 11, 2026
| Endpoint: "/apps/" + app + "/private_network_domain_names?" + params.Encode(), | ||
| } | ||
| var domainRes PrivateNetworkDomainsRes | ||
| err = c.ScalingoAPI().DoRequest(ctx, req, &domainRes) |
Member
Author
There was a problem hiding this comment.
We should not use DoRequest if the use of the functions in the http.Client interface are possible. Here we can easily use SubresourceList.
EtienneM
requested review from
a team,
matthieu526-scalingo and
sc-david-voisin
and removed request for
a team and
matthieu526-scalingo
sc-david-voisin
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This the convention in the other functions using the pagination.
Related to Scalingo/cli#1147
Tested in Scalingo/cli#1203