Skip to content

feat(pagination): add json tag to Request#1493

Closed
EtienneM wants to merge 1 commit intomasterfrom
feat/pagination/json_tag
Closed

feat(pagination): add json tag to Request#1493
EtienneM wants to merge 1 commit intomasterfrom
feat/pagination/json_tag

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 3, 2026

This is useful in go-scalingo so that we don't need to convert the pagination.Request to a map[string]string.

This is used in the change introduced in Scalingo/go-scalingo#484

  • Add a changelog entry in CHANGELOG.md

@EtienneM EtienneM self-assigned this Mar 3, 2026
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch from b0b0c6e to 687af8f Compare March 3, 2026 08:22
@EtienneM
Copy link
Member Author

EtienneM commented Mar 3, 2026

This is a non-sense. pagination.Request is converted to query params, it's not JSON-encoded.

@EtienneM EtienneM closed this Mar 3, 2026
@EtienneM EtienneM deleted the feat/pagination/json_tag branch March 3, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant